Fix regressions #414
Merged
Fix regressions #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 21, 2022
While we previously removed the ProgressBar's state from the MultiProgressState, we did not remove the remote draw target from the bar's draw target, so that it could start to draw into the MultiProgress state again in surprising ways.
This might hide the panic output, making it extremely confusing how the process might have ended.
In #395, we made it so that message and prefix are carried over when calling ProgressBar::with_style(), but this did not change ProgressBar::set_style(). Reuse the same logic by having with_style() call set_style(), so that these cannot fall out of sync again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412, #413.