Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor finish behavior #384

Merged
merged 6 commits into from
Feb 18, 2022
Merged

Refactor finish behavior #384

merged 6 commits into from
Feb 18, 2022

Commits on Feb 18, 2022

  1. Extract constructor function for BarState

    @djc
    djc committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    400535f View commit details
    Browse the repository at this point in the history

  2. Pass owned ProgressFinish into finish_using_style()

    @djc
    djc committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    6c38a26 View commit details
    Browse the repository at this point in the history

  3. Inline finish helper methods

    @djc
    djc committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    8b9a1f6 View commit details
    Browse the repository at this point in the history

  4. Convert remaining API to using finish_using_style()

    @djc
    djc committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    0ed8905 View commit details
    Browse the repository at this point in the history

  5. Extract common handling of finish behavior

    @djc
    djc committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    81c706c View commit details
    Browse the repository at this point in the history

  6. Remove duplicate API 

    finish_using_current_pos() was equivalent to using abandon().
    @djc
    djc committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    ad228c2 View commit details
    Browse the repository at this point in the history