Make unreachable width actually unreachable
#287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally `width` is only called after `is_hidden` returns false but in the case of a `ProgressDrawTargetKind::Remote` it always returned false even if the draw target was actually hidden and because of it drawing did call `width`
|
With this patch it seems that indicatif deadlocks for me. |
|
Closed in favor of #286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally
widthis only called afteris_hiddenreturns false but inthe case of a
ProgressDrawTargetKind::Remoteit always returnedfalse even if the draw target was actually hidden and because of it
drawing did call
widthAlternative to #286, fixes #285
cc @matthiasbeyer I'm pretty sure this fixes the problem, but just to be certain could you check?