Panic in AtomicPosition::allow

[arxanas]

This is the panic, from this CI run:

The application panicked (crashed).
Message:  attempt to add with overflow
Location: C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\indicatif-0.17.0-rc.9\src\state.rs:420

It corresponds to this line:

indicatif/src/state.rs

Line 420 in ea1f733

capacity = Ord::min(MAX_BURST, capacity + new as u8 - 1);

Note that this is an addition which is overflowing, unlike the subtractions which are addressed in #403 and #404.

[chris-laplante]

Yep, this is the crash I've seen too. I still can't wrap my head around what is actually causing these though.

[djc]

Well, if capacity + new is larger than 255, that would do it? And that would happen if there's a long wait between increments.

We could just do capacity.saturating_add(new) - 1.

[chris-laplante]

Well, if capacity + new is larger than 255, that would do it? And that would happen if there's a long wait between increments.

We could just do capacity.saturating_add(new) - 1.

Yes. And yeah, I guess it has to be long waits that's causing it.

Side note, but I hit this a few weeks ago and have been meaning to mention it: rust-lang/rust#86470. It is not an indicatif bug, but rather something that was fixed in Rust. Let's maybe just keep an eye out for issue reports that may involve it.