Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undeprecate is_term #86

Closed
mitsuhiko opened this issue Feb 1, 2021 · 2 comments · Fixed by alex/csv-sql#509, alex/ex-post-progress#144, ffizer/ffizer#365, emmanuel099/specbmc#15 or foresterre/cargo-msrv#51
Closed

Undeprecate is_term #86

mitsuhiko opened this issue Feb 1, 2021 · 2 comments · Fixed by alex/csv-sql#509, alex/ex-post-progress#144, ffizer/ffizer#365, emmanuel099/specbmc#15 or foresterre/cargo-msrv#51

Comments

@mitsuhiko
Copy link
Collaborator

@pksunkara can we undeprecate is_term? It's such a common operation and now you need to use a much more complex API to use it.
@pksunkara
Copy link
Collaborator

Okay, I thought you wanted to move everything to features() when I took over the code which is why I deprecated it.

@mitsuhiko
Copy link
Collaborator Author

I think it's fine to keep. I mostly noticed because indicatif started causing deprecation warnings when using latest console and I did not really like the upgrade experience :)

@dtolnay dtolnay mentioned this issue Mar 7, 2021
Closed
This was referenced Mar 15, 2021
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
dtolnay pushed a commit to dtolnay-contrib/console that referenced this issue Feb 4, 2022
@seanmonstar
subscriber: add ability to record events to a file (console-rs#86)
4fc72c0 
Closes console-rs#84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mitsuhiko @pksunkara