Support for DELETE requests in the "CurlClient" class #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is a valid point and couple of PRs (not merged yet) proves that it's really needed. Unless the DELETE requests have any POST parameters please change implementation to one from here: https://github.com/chobie/jira-api-restclient/pull/53/files#diff-bac9579c3d575193a096385b414bc909 (this is diff from not yet merged PR). |
aik099
changed the title
aik099
changed the title
|
Please rebase and solve conflicts. |
This was referenced Jun 29, 2016
Closed
|
Your changes were incorporated into #108. Thank you, @zimmermanj42 . |
|
Changes moved to #115. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current CURL implementation does not acknowledge DELETE requests. This fix allows for the HTTP DELETE verb to be used with the CURL wrapper.
However, all DELETE requests return "(bool) false" from within the "Api::api()" function call. It appears that the Api class was not built really with DELETE calls in mind. If the "Api::api()" function specifies how DELETE requests should return, I could also probably fix that as well.