Fix create attachments for PHP 5.5 #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me to be used in Jira for the attachments. PHPDoc improvements.
This reverts commit c362599.
|
Thank you.
If that doesn't work for you, please open another issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having problems with the createAttachment() using PHP 5.6. Turns out there is a new way to handle file uploads in Curl from PHP 5.5 and above: the function curl_file_create().
I also provided a way to specify the file name you want to use in Jira for the attachment you're uploading. It shouldn't break existing code, it's an optional parameter. If unused the filename defaults to basename() of the file you provide.
And I improved on some PHPDocs. Sorry, it's a fetish of mine...