Adding instrucment #762
Merged
Adding instrucment #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Akosh Farkash <aakoshh@gmail.com>
Co-authored-by: Akosh Farkash <aakoshh@gmail.com>
…yard/ipc into topdown-lost-commits
aakoshh
reviewed
Feb 29, 2024
| @@ -44,6 +46,7 @@ fn init_tracing(opts: &options::Options) -> Option<WorkerGuard> { | |||
| fmt::Layer::new() | |||
| .json() | |||
| .with_writer(non_blocking.with_max_level(log_level)) | |||
| .with_span_events(FmtSpan::CLOSE) | |||
There was a problem hiding this comment.
The documentation is a bit short in exact details, but I think if we use FmtSpan::CLOSE only like here then the generated event will also contain the total time the span was entered (+ time the span existed but was not entered).
aakoshh
suggested changes
Feb 29, 2024
There was a problem hiding this comment.
Sorry, just noticed that the tests are actually failing: https://github.com/consensus-shipyard/ipc/actions/runs/8098552876/job/22132258717
aakoshh
approved these changes
Feb 29, 2024
fridrik01
approved these changes
Mar 1, 2024
| @@ -44,6 +46,7 @@ fn init_tracing(opts: &options::Options) -> Option<WorkerGuard> { | |||
| fmt::Layer::new() | |||
| .json() | |||
| .with_writer(non_blocking.with_max_level(log_level)) | |||
| .with_span_events(FmtSpan::CLOSE) | |||
There was a problem hiding this comment.
The documentation is a bit short in exact details, but I think if we use FmtSpan::CLOSE only like here then the generated event will also contain the total time the span was entered (+ time the span existed but was not entered).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
#[instrument]to debug topdown syncer performance issue.