Multisubnet test #736
Merged
Multisubnet test #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 22, 2024 15:50
| executeTopDownMsgs(msgs, nativeSubnetName, address(nativeSubnetGateway)); | ||
|
|
||
| // works with no state changes | ||
| assertEq(recipient.balance, amount); |
There was a problem hiding this comment.
I think this test would be easier to understand this test if it started with
- recipient/parent having balance=3
- caller/child having balance=0
This way the reader could imagine that the initial state of the tests is when the child released its balance completely.
|
|
||
| executeTopDownMsgs(msgs, nativeSubnetName, address(nativeSubnetGateway)); | ||
|
|
||
| require(caller.balance == amount + amount, "refund not happening"); |
There was a problem hiding this comment.
Same comment as above about initial balances as this amount + amount assertion is a bit confusing now.
maciejwitowski
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-747
Adding more multisubnet test cases.