Fund with token #504
Merged
Fund with token #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
approved these changes
Jan 2, 2024
| to: Option<Address>, | ||
| amount: TokenAmount, | ||
| ) -> anyhow::Result<ChainEpoch> { | ||
| let parent = subnet.parent().ok_or_else(|| anyhow!("no parent found"))?; |
There was a problem hiding this comment.
Does it make sense to perform a sanity check that the subnet indeed has a ERC20 supply source? If not, it will be caught anyway by the gateway actor, so probably not worth it. However, is this able to return the corresponding Solidity exception in a human-friendly form?
There was a problem hiding this comment.
yep, should be able to. From past experience, in contract execution, errors are usually returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
fund_with_tokenapi for erc20 token transfers, see here.