Skip to content

Commit

Permalink
update linter rules and fix
Browse files Browse the repository at this point in the history
  • Loading branch information
charlesjhongc committed Aug 22, 2023
1 parent c299226 commit 149f58f
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 7 deletions.
18 changes: 13 additions & 5 deletions .solhint.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,28 @@
"extends": "solhint:recommended",
"plugins": ["prettier"],
"rules": {
"constructor-syntax": "error",
"payable-fallback": "error",
"explicit-types": "error",
"max-states-count": "error",
"no-console": "error",
"no-empty-blocks": "error",
"no-global-import": "error",
"no-unused-import": "error",
"no-unused-vars": "error",
"prettier/prettier": "error",
"payable-fallback": "error",
"constructor-syntax": "error",
"comprehensive-interface": "warn",
"func-named-parameters": "warn",
"imports-on-top": "error",
"ordering": "warn",
"visibility-modifier-order": "error",
"avoid-call-value": "error",
"avoid-sha3": "error",
"avoid-suicide": "error",
"avoid-throw": "error",
"avoid-tx-origin": "off",
"check-send-result": "error",
"compiler-version": ["error", ">=0.6.0"],
"compiler-version": ["error", ">=0.8.0"],
"func-visibility": ["error", { "ignoreConstructors": true }],
"mark-callable-contracts": "off",
"multiple-sends": "error",
"no-complex-fallback": "error",
"no-inline-assembly": "warn",
Expand Down
1 change: 0 additions & 1 deletion contracts/AMMStrategy.sol
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
pragma solidity 0.8.17;

import { IERC20 } from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
import { ERC20 } from "@openzeppelin/contracts/token/ERC20/ERC20.sol";
import { SafeERC20 } from "@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol";

import { Ownable } from "./abstracts/Ownable.sol";
Expand Down
2 changes: 1 addition & 1 deletion contracts/interfaces/IUniswapV3SwapRouter.sol
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-or-later
pragma solidity >=0.8.0;

import "./IUniswapV3SwapCallback.sol";
import { IUniswapV3SwapCallback } from "./IUniswapV3SwapCallback.sol";

/// @title Router token swapping functionality
/// @notice Functions for swapping tokens via Uniswap V3
Expand Down

0 comments on commit 149f58f

Please sign in to comment.