refactor signatureValidator #498
Triggered via pull request
September 13, 2023 03:24
charlesjhongc
Status
Success
Total duration
2m 56s
Artifacts
–
Annotations
11 warnings
|
build (16.x)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build (16.x):
contracts/AllowanceTarget.sol#L23
Error message for require is too long
|
|
build (16.x):
contracts/AllowanceTarget.sol#L30
Error message for require is too long
|
|
build (16.x):
contracts/AllowanceTarget.sol#L31
Error message for require is too long
|
|
build (16.x):
contracts/AllowanceTarget.sol#L33
Avoid to make time-based decisions in your business logic
|
|
build (16.x):
contracts/AllowanceTarget.sol#L38
Error message for require is too long
|
|
build (16.x):
contracts/AllowanceTarget.sol#L39
Error message for require is too long
|
|
build (16.x):
contracts/AllowanceTarget.sol#L39
Avoid to make time-based decisions in your business logic
|
|
build (16.x):
contracts/AllowanceTarget.sol#L58
Avoid to use low level calls
|
|
build (16.x):
contracts/AllowanceTarget.sol#L61
Avoid to use inline assembly. It is acceptable only in rare cases
|
|
build (16.x):
contracts/AMMQuoter.sol#L27
Variable name must be in mixedCase
|