Chore: cleanup and upgrade codebase #551
alex0207sAnnotations
12 warnings
|
build (16.x)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build (16.x)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L19
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L20
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L31
Named parameters missing. MIN unnamed argumenst is 4
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L47
Function order is incorrect, internal view function can not go after private view function (line 36)
|
|
build (16.x):
contracts/abstracts/EIP712.sol#L53
Function name must be in mixedCase
|
|
build (16.x):
contracts/abstracts/Ownable.sol#L30
Function order is incorrect, event definition can not go after custom error definition (line 26)
|
|
build (16.x):
contracts/abstracts/TokenCollector.sol#L25
Function order is incorrect, enum definition can not go after custom error definition (line 20)
|
|
build (16.x):
contracts/abstracts/TokenCollector.sol#L33
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
build (16.x):
contracts/abstracts/TokenCollector.sol#L34
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
build (16.x):
contracts/abstracts/TokenCollector.sol#L59
Avoid to use low level calls
|