Add support for displaying icons in the Rails app #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to almost be working, but it requires me to run `rake assets:precompile` because it's looking in the `public/` directory.
I can't figure out how to get the webpack-dev-server to load these itself, it needs to be precompiled, but oh well at least these don't change often so it shouldn't be much of a problem.
Add InlineSvg to the sorbet-rails helpers generation, to make sure that the inline_svg_pack_tag is available in application_helper.rb.
connorshea
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was pretty annoying to get working, and it requires running
rake assets:precompileto get the icons to show up with webpacker.You can use the
svg_iconhelper I've created like so:I haven't added any icons to the app yet because I don't see a great place to get started with it and just want to get this merged for now.
This uses icons from font-awesome.
Resolves #121.