Skip to content

Split Steam AppIDs into separate model #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 19, 2019

Conversation

connorshea
Copy link
Owner

@connorshea connorshea commented Oct 19, 2019

This splits the Steam AppIDs into a separate model so that a game can have multiple Steam App IDs.

It updates the Wikidata importer, Steam importer, game form, and game infobox. As well as any related tests. It doesn't remove the steam_app_id column entirely yet, I'll do that in a separate PR after I've validated that the migration to the new system worked.

TODO:

  • Make sure the Wikidata importer continues to work properly.
  • Create a migration for moving existing Steam AppIDs and test the hell out of it.
  • Probably add more tests.
  • Reword the importer note about special editions.

I'll add Steam App IDs to the GraphQL Game object in a separate PR.

@connorshea connorshea marked this pull request as ready for review October 19, 2019 23:35
@connorshea connorshea merged commit 830088d into master Oct 19, 2019
@connorshea connorshea deleted the split-steam-app-ids-into-separate-model branch October 19, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant