Skip to content
This repository has been archived by the owner on Dec 24, 2020. It is now read-only.

Add a graphs controller. #12

Merged
merged 11 commits into from
Apr 28, 2018
Merged

Add a graphs controller. #12

merged 11 commits into from
Apr 28, 2018

Conversation

connorshea
Copy link
Owner

@connorshea connorshea commented Apr 19, 2018

  • Adds better_errors gem
  • Adds the ability to run USE_TEST_DATA=true bundle exec rake db:seed in order to run the application in development mode with the test data.
  • Changes the default value for the browser columns in the feature table to nil instead of '{}'
  • Adds graphs pages

TODO:

  • The graph values don't quite add up when there are more complex browser support objects, e.g. it handles { version_added: true } but I'm not 100% sure it handles { version_added: true, prefix: '-webkit'} and it definitely doesn't handle support objects that are arrays of these hashes.

@connorshea connorshea force-pushed the add-graphs-page branch 4 times, most recently from 25ee143 to eadf10d Compare April 28, 2018 20:14
@connorshea
Copy link
Owner Author

connorshea commented Apr 28, 2018

I don't want this PR to become too complicated, so I'm going to merge it now. The results on the graphs page aren't entirely representative, but it's good enough for now.

I'll add proper tests in a separate PR, maybe using factories?

screen shot 2018-04-28 at 3 24 32 pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant