-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't merge: Demonstrate dual package hazard #1002
Conversation
@smaye81, can you take a look? From the code size benchmark in connect-es, tree-shaking in esbuild works, but it would be good to have confidence that that's also true for other bundlers like webpack and parcel. |
Seems like we see a bunch of segfaults in parcel: parcel-bundler/parcel#5961
…, but it also is not maintained anymore.
Thanks @smaye81 and @paul-sachs. I've moved the tree-shaking tests out to a separate project here, and added bundlers to the dual package hazard example here. The results with the fix from connectrpc/connect-es#842 are:
|
This example demonstrates the dual package hazard and verifies the fix by connectrpc/connect-es#842.
For a repeatable example for the dual package hazard with various consumers see here.
For tree-shaking tests with various bundlers see here.