Update Python docs for v0.8.0 release #318
Conversation
|
@anuraaga is attempting to deploy a commit to the connectrpc Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
anuraaga
force-pushed
the
python-0.8.0-docs
branch
from
7f6da5f to
ee1586c
Compare
stefanvanburen
left a comment
stefanvanburen
left a comment
There was a problem hiding this comment.
just nits on the codeblocks; lgtm otherwise.
docs/python/grpc-compatibility.mdx
Outdated
| Connect-Python currently does not provide implementations of gRPC standard endpoints like reflection | ||
| and health check but likely will in the future. |
There was a problem hiding this comment.
+1 on adding these; not sure if they make sense as separate projects under the connect umbrella, separate workspaces in connect-python, or just bundled in with the base project?
There was a problem hiding this comment.
Good question - not sure but I think multiple packages in the connect-python repo could make sense
Co-authored-by: Stefan VanBuren <stefan@vanburen.xyz> Signed-off-by: Anuraag (Rag) Agrawal <anuraaga@gmail.com>
|
I should be able to give this all a proofreading today (afternoon Eastern US time). |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: jrinehart-buf <jrinehart@buf.build>
| for message in request: | ||
| greeting += f"Hello, {message.name}!\n" | ||
| response = GreetResponse(greeting=f"Hello, {request.name}!") | ||
| response = GreetResponse(greeting=greeting) |
There was a problem hiding this comment.
@anuraaga - I think this was a small bug. Did I fix it correctly?
|
@anuraaga - I've added a commit with minor copy fixes and what I think is a correction in a streaming example. If that all looks good, this is good to go. A Vercel preview has been deployed. |
|
Thanks a lot for the fixes @jrinehart-buf! |
|
No problem @anuraaga , thanks for the contributions! |
3 participants
Notably has full support for gRPC now.
While most of the doc updates are in the testing page that is probably lowish impact, will both block this on connectrpc/connect-python#91 and vice-versa.