Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Remove defaultOptions #445

Merged
merged 1 commit into from
Oct 8, 2024
Merged

V2: Remove defaultOptions #445

merged 1 commit into from
Oct 8, 2024

Conversation

timostamm
Copy link
Member

@connectrpc/connect-query exports defaultOptions for the QueryClient. In v1, it provides queryKeyHashFn with a hash implementation that support BigInt (npm package "stable-hash").

In v2, query keys do not include BigInt values anymore, and the defaultOptions object is empty. This removes the export.

Signed-off-by: Timo Stamm <ts@timostamm.de>
@timostamm timostamm requested a review from paul-sachs October 8, 2024 11:42
Copy link
Collaborator

@paul-sachs paul-sachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@timostamm timostamm merged commit bf9728f into v2 Oct 8, 2024
7 checks passed
@timostamm timostamm deleted the tstamm/v2/Remove-defaultOptions branch October 8, 2024 13:16
@timostamm timostamm mentioned this pull request Oct 9, 2024
@timostamm timostamm mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants