Skip to content

Conversation

@Zaczero
Copy link
Contributor

@Zaczero Zaczero commented Feb 7, 2026

They are valid protobuf, otherwise we get errors like

{
    "code": "invalid_argument",
    "message": "'message' parameter is required for GET requests"
}

@anuraaga anuraaga changed the title Fix empty payloads Send GET params for empty request messages Feb 9, 2026
@anuraaga
Copy link
Collaborator

anuraaga commented Feb 9, 2026

Thanks @Zaczero! This looks good, can you sign off the commit for the DCO check?

Signed-off-by: Kamil Monicz <kamil@monicz.dev>
@Zaczero Zaczero force-pushed the zaczero/bizarre-chipmunk branch from e9a27b5 to 6dff59d Compare February 9, 2026 02:18
@Zaczero
Copy link
Contributor Author

Zaczero commented Feb 9, 2026

@anuraaga done, btw this fixes both receiving and sending

@anuraaga anuraaga changed the title Send GET params for empty request messages Process GET params for empty request messages Feb 9, 2026
Copy link
Collaborator

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anuraaga anuraaga merged commit 5043824 into connectrpc:main Feb 9, 2026
23 checks passed
@Zaczero Zaczero deleted the zaczero/bizarre-chipmunk branch February 9, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants