Skip to content

[REFACTORING] Change to consumer can use scrollLock to toggle #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nnnnnoel wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[REFACTORING] Change to consumer can use scrollLock to toggle #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 23 additions & 13 deletions src/hooks/useScrollLock/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,27 @@
import { useEffect, useState } from "react";
import { useCallback, useEffect, useState } from 'react';

export const useScrollLock = (on: boolean) => {
useEffect(() => {
const body = window.document.getElementsByTagName("body")[0];
if (on) {
body && (body.style.overflow = "hidden");
} else {
body && (body.style.overflow = "scroll");
}
return () => {
body && (body.style.overflow = "scroll");
};
}, [on]);
export const useScrollLock: (initialFlag?: boolean) => [boolean, () => void] = (
initialFlag = false
) => {
const [flag, setFlag] = useState<boolean>(initialFlag);

const toggleFlag = useCallback(() => {
setFlag(prevFlag => !prevFlag);
}, []);

useEffect(() => {
const body = window.document.getElementsByTagName('body')[0];
if (flag) {
body.style.overflow = 'hidden';
} else {
body.style.overflow = 'scroll';
}
return () => {
body.style.overflow = 'scroll';
};
}, [flag]);

return [flag, toggleFlag];
Copy link
Member

@Jeontaeyun Jeontaeyun Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏷조금 더 자유도를 높이는 방안으로 변경된 것 같네요 혹시 이 부분을 onToggleFlag 로 네이밍을 수정할까 하는데, 제가 바꿔서 다시 여기에 추가할 수 있나요?

};

export default useScrollLock;