[REFACTORING] Simplify useMediaQeury code #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeontaeyun
reviewed
Apr 21, 2020
| return afterSize - beforeSize; | ||
| }); | ||
|
|
||
| return Object.fromEntries(configEntries); |
Member
There was a problem hiding this comment.
🏷 Object.fromEntries()
translate key-value to object like ["key","value"] => { key : value }
|
|
||
| function sortConfigWithSize(config: IResponsibleHookConfig, order: Order = 'ASC') { | ||
| const configEntries = Object.entries(config); | ||
| configEntries.sort((before, after) => { |
Member
There was a problem hiding this comment.
🏷Tip
array.sort()를 실행하면 내부적으로 정렬된 값이 array에 반영되어 따로 할당할 필요가 없다.
이 부분 새롭게 알아갑니다. 감사합니다.
Jeontaeyun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.