Remove ref qualifier but leave overload for compatibility. #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roederja2 - The change looks functionally fine, but can you fill me in on the motivation for this change? |
|
It's just that the ref is not required and it makes the method awkward to call. |
|
Thanks. Just checking. (I think this code probably dates back to the original project coders following the C++ example too closely.) |
gbirchmeier
added a commit
to gbirchmeier/quickfixn
that referenced
this pull request
Mar 2, 2020
Merged
gbirchmeier
added a commit
to gbirchmeier/quickfixn
that referenced
this pull request
Mar 2, 2020
gbirchmeier
added a commit
that referenced
this pull request
Mar 2, 2020
make UTs not call things deprecated by #570
hlibman-connamara
pushed a commit
to hlibman-connamara/quickfixn
that referenced
this pull request
Dec 6, 2024
Remove ref qualifier but leave overload for compatibility.
hlibman-connamara
pushed a commit
to hlibman-connamara/quickfixn
that referenced
this pull request
Dec 6, 2024
hlibman-connamara
pushed a commit
to hlibman-connamara/quickfixn
that referenced
this pull request
Dec 6, 2024
hlibman-connamara
pushed a commit
to hlibman-connamara/quickfixn
that referenced
this pull request
Dec 6, 2024
hlibman-connamara
pushed a commit
to hlibman-connamara/quickfixn
that referenced
this pull request
Dec 6, 2024
make UTs not call things deprecated by connamara#570
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.