Do not ignore MsgSeqNum on ResendRequest when no persistence #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gbirchmeier
added a commit
to gbirchmeier/quickfixn
that referenced
this pull request
Mar 2, 2020
Merged
hlibman-connamara
pushed a commit
to hlibman-connamara/quickfixn
that referenced
this pull request
Dec 6, 2024
Do not ignore MsgSeqNum on ResendRequest when no persistence
hlibman-connamara
pushed a commit
to hlibman-connamara/quickfixn
that referenced
this pull request
Dec 6, 2024
hlibman-connamara
pushed a commit
to hlibman-connamara/quickfixn
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MsgSeqNum on ResendRequest messages is currently ignored when message persistence is disabled. Hence, when a new message is received following a ResendRequest its validation fails as the expected target sequence number is one down from the actual (since the one on ResendRequest was ignored). This should be fixed.