-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow groups where the first entry is a group #513
Conversation
rather than a field. Currently, this results in the GroupDelimiterTagException "Group 123's first entry does not start with delimiter 0" N.B. This is only very lightly tested
If I understand you right, I'm fairly sure this isn't legal FIX. Do you have a real-world example that I can see? |
Not sure if it is "legal", but it's in the upcoming spec of an exchange and we need to implement it. Here is the specification of the payload of that custom message which I couldn't get to run, before applying this PR:
It fails parsing group 1669, because there is no field directly following the NumInGroup field, but a group. |
I will take a look tomorrow. On second look, I see no logical reason why a group counter can't also be the delimiter of the parent group. |
@gbirchmeier If tomorrow never comes... :-P Just joking. It's not urgent for me anyway, as I am building from a fork of quickfixn, but I wanted to let you know that I've let this run for these 18 days now in our test environment, and there were no problems with it. |
Haha, oops! Still got the tab open. I hope to get back to it before too long. |
Allow groups where the first entry is a group (adapted #513 and added tests)
Allow groups where the first entry is a group (adapted connamara#513 and added tests)
rather than a field.
Currently, this results in the GroupDelimiterTagException "Group 123's first entry does not start with delimiter 0"
N.B. I have tested this only very lightly so far, and it addresses the problem