Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow groups where the first entry is a group #513

Closed
wants to merge 1 commit into from
Closed

Allow groups where the first entry is a group #513

wants to merge 1 commit into from

Conversation

twoi
Copy link
Contributor

@twoi twoi commented Feb 18, 2019

rather than a field.

Currently, this results in the GroupDelimiterTagException "Group 123's first entry does not start with delimiter 0"

N.B. I have tested this only very lightly so far, and it addresses the problem

rather than a field.

Currently, this results in the GroupDelimiterTagException "Group 123's first entry does not start with delimiter 0"

N.B. This is only very lightly tested
@gbirchmeier
Copy link
Member

If I understand you right, I'm fairly sure this isn't legal FIX. Do you have a real-world example that I can see?

@twoi
Copy link
Contributor Author

twoi commented Feb 19, 2019

Not sure if it is "legal", but it's in the upcoming spec of an exchange and we need to implement it.

Here is the specification of the payload of that custom message which I couldn't get to run, before applying this PR:

 Tag   Tag   Tag   Tag   Field Name              Type        Req'd 
-------------------------------------------------------------------
 1666                    RiskLimitRequestID      String      Y     
 1677                    NoPartyRiskLimits       NumInGroup  Y     
 ->    1324              ListUpdateAction        char        Y     
 ->    1669              NoRiskLimits            NumInGroup  Y     
 ->    ->    1529        NoRiskLimitTypes        NumInGroup  Y     
 ->    ->    ->    1530  RiskLimitType           int         Y     
 ->    ->    ->    1531  RiskLimitAmount         Amt         N     
 ->    ->    1534        NoRiskInstrumentScopes  NumInGroup  N     
 ->    ->    ->    1536  InstrumentScopeSymbol   String      N     

It fails parsing group 1669, because there is no field directly following the NumInGroup field, but a group.

@gbirchmeier
Copy link
Member

gbirchmeier commented Feb 19, 2019

I will take a look tomorrow. On second look, I see no logical reason why a group counter can't also be the delimiter of the parent group.

@twoi
Copy link
Contributor Author

twoi commented Mar 8, 2019

@gbirchmeier If tomorrow never comes... :-P Just joking.

It's not urgent for me anyway, as I am building from a fork of quickfixn, but I wanted to let you know that I've let this run for these 18 days now in our test environment, and there were no problems with it.

@gbirchmeier
Copy link
Member

Haha, oops! Still got the tab open. I hope to get back to it before too long.

gbirchmeier added a commit to gbirchmeier/quickfixn that referenced this pull request Jul 17, 2019
gbirchmeier added a commit to gbirchmeier/quickfixn that referenced this pull request Jul 17, 2019
gbirchmeier added a commit to gbirchmeier/quickfixn that referenced this pull request Jul 17, 2019
gbirchmeier added a commit that referenced this pull request Jul 18, 2019
Allow groups where the first entry is a group (adapted #513 and added tests)
hlibman-connamara pushed a commit to hlibman-connamara/quickfixn that referenced this pull request Dec 6, 2024
hlibman-connamara pushed a commit to hlibman-connamara/quickfixn that referenced this pull request Dec 6, 2024
hlibman-connamara pushed a commit to hlibman-connamara/quickfixn that referenced this pull request Dec 6, 2024
Allow groups where the first entry is a group (adapted connamara#513 and added tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants