Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Jenkins pipeline #27

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Conversation

izgeri
Copy link
Contributor

@izgeri izgeri commented Sep 10, 2018

Resolves #26

Add a Jenkins pipeline to this repository that will run the start scripts and fail on error.
Currently only GKE is supported, with plans to support OpenShift in the future.

Also updates the verification script so that it will wait until the service is available before performing the verification check.

green build
To get the build green, I had to temporarily hardcode the v5 appliance to 5.1.2 (5.0-stable sometimes is not working in K8s right now).

Please do not squash merge.

@izgeri izgeri self-assigned this Sep 10, 2018
@izgeri izgeri force-pushed the 26-add-gke-test-to-jenkins branch 14 times, most recently from 5727b5a to 55b21cd Compare September 11, 2018 18:04
@izgeri izgeri changed the title Adding Jenkins pipeline WIP - Adding Jenkins pipeline Sep 12, 2018
@izgeri izgeri force-pushed the 26-add-gke-test-to-jenkins branch 6 times, most recently from 9ac521e to 6bb630f Compare September 12, 2018 22:09
Add a Jenkins pipeline to this repository that will run the start scripts
and fail on error.
Currently only GKE is supported, with plans to support OpenShift in the future.
@izgeri izgeri changed the title WIP - Adding Jenkins pipeline Adding Jenkins pipeline Sep 13, 2018
Update 7_verify_authentication.sh so that it waits for the services to become
available before querying them

Additionally, update the is_minienv check in utils.sh so that it works when
minishift is not installed
Copy link
Contributor

@doodlesbykumbi doodlesbykumbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work ✨

@doodlesbykumbi doodlesbykumbi merged commit 6b8feec into master Sep 13, 2018
@doodlesbykumbi doodlesbykumbi deleted the 26-add-gke-test-to-jenkins branch September 13, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants