CNJR-0000: Use alpine instead of Ruby base image #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szh
force-pushed
the
snyk-fixes
branch
5 times, most recently
from
6f47819 to
338d760
Compare
szh
force-pushed
the
snyk-fixes
branch
4 times, most recently
from
5e429ff to
b13fcaa
Compare
jtuttle
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be any real reason we're using the Ruby base image for the summon test app. Summon is written in Go, and besides we're installing the compiled version. The Ruby image is large and has therefore has a large attack surface and many packages with vulnerabilities. Switching to a slimmer base image such as Alpine reduces attack surface and vulnerabilities.
While testing this, I discovered that Jenkins tests on OpenShift were failing due to the google/cloud-sdk base image used in tests no longer having the correct glibc version needed by the OpenShift CLI. I decided to switch from the (very large) google/cloud-sdk image to a plain ubuntu image and download the Google Cloud CLI as described in https://cloud.google.com/sdk/docs/install#deb