Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds host IDs for validating basic authentication #140

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

diverdane
Copy link
Contributor

This change adds two host IDs that can be used to validate basic authentication (i.e. no secrets access is required) with a Conjur instance. The two host IDs are intended for:

  • Validating authentication with Conjur after the Kubernetes cluster has been configured for Conjur authn-k8s support
  • Validating authentication with Conjur after an application Namespace has been configured for Conjur authn-k8s support

respectively.

Copy link
Contributor

@rpothier rpothier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit.

This change adds two host IDs that can be used to validate basic authentication
(i.e. no secrets access is required) with a Conjur instance. The two host
IDs are intended for:

- Validating authentication with Conjur after the Kubernetes cluster has
  been configured for Conjur authn-k8s support
- Validating authentication with Conjur after an application Namespace has
  been configured for Conjur authn-k8s support

respectively.
@diverdane diverdane force-pushed the 135-add-validator-ids branch from 511d1b4 to 625930e Compare July 21, 2021 19:03
@diverdane diverdane merged commit 8a34bc2 into main Jul 21, 2021
@diverdane diverdane deleted the 135-add-validator-ids branch July 21, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants