Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ci docker run command #138

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Update ci docker run command #138

merged 1 commit into from
Jun 3, 2021
+7 −2

Conversation

izgeri
Copy link
Contributor

@izgeri izgeri commented Jun 1, 2021

Only include GCLOUD_SERVICE_KEY in docker run env var if it's set and non
empty

@izgeri izgeri self-assigned this Jun 1, 2021
@izgeri izgeri force-pushed the fix-broken-build branch 3 times, most recently from 3202707 to 5127e30 Compare June 2, 2021 16:45
hughsaunders
hughsaunders reviewed Jun 2, 2021
View reviewed changes
@ismarc ismarc force-pushed the fix-broken-build branch 4 times, most recently from 24be017 to f2d34ca Compare June 3, 2021 19:02
@ismarc ismarc requested a review from hughsaunders June 3, 2021 19:02
izgeri
izgeri commented Jun 3, 2021
View reviewed changes
izgeri
izgeri commented Jun 3, 2021
View reviewed changes
Copy link
Contributor Author

@izgeri izgeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR that I opened but that @ismarc resolved

@ismarc ismarc merged commit ab6e977 into main Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismarc ismarc ismarc approved these changes

@hughsaunders hughsaunders Awaiting requested review from hughsaunders

Assignees

@izgeri izgeri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izgeri @ismarc @hughsaunders