Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten name of flow to get tests passing in OCP 4.7 #137

Merged
merged 1 commit into from
May 17, 2021

Conversation

izgeri
Copy link
Contributor

@izgeri izgeri commented May 17, 2021

The test-app-with-host-outside-apps-branch-summon-init flows exceeded the 63 char limit in OCP 4.7, leading to errors in the pipeline that looked like this:

[2021-05-13T18:47:47.852Z] deploymentconfig.apps.openshift.io/test-app-with-host-outside-apps-branch-summon-init created
[2021-05-13T18:47:47.852Z] The Route "test-app-with-host-outside-apps-branch-summon-init" is invalid: spec.host: Invalid value: "test-app-with-host-outside-apps-branch-summon-init-test-app-5-89f9f44a-2.apps.openshift-47-fips-enc.ci.conjur.net": host must conform to DNS 1123 naming conventions: [spec.host: Invalid value: "test-app-with-host-outside-apps-branch-summon-init-test-app-5-89f9f44a-2": must be no more than 63 characters]

In this PR, we update the name of those flows to something shorter. You can see them passing in OCP 4.7 here.

@izgeri izgeri self-assigned this May 17, 2021
test-app-with-host-outside-apps-branch-summon-init exceeded 63 char limit in
OCP 4.7
@izgeri izgeri force-pushed the validate-ocp-47 branch from d6670da to 8ae6447 Compare May 17, 2021 20:52
Copy link
Contributor

@imheresamir imheresamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

imheresamir
imheresamir approved these changes May 17, 2021
@imheresamir imheresamir merged commit a4272e3 into master May 17, 2021
@imheresamir imheresamir deleted the validate-ocp-47 branch May 17, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants