Eliminates duplicate CONJUR_OSS_HELM_RELEASE by using HELM_RELEASE #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scripts currently require that the environment variable CONJUR_OSS_HELM_RELEASE be set. This environment variable is set in our CI test scripts, but typical users of these scripts would not be aware that this setting is required. Fix is to use the HELM_RELEASE environment variable that users are already aware of in our CI. Addresses Issue #133
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scripts currently require that the environment variable
CONJUR_OSS_HELM_RELEASEbe set. This environment variable is set in our CI test scripts, but typical users of these scripts would not be aware that this setting is required.Fix is to (re)use the
HELM_RELEASEenvironment variable (something that users are already aware of) in our CI.Addresses Issue #133