Fix multi/dual when no right y axis (apache#6571)

conglei · Jan 7, 2019 · 8b0cfa7 · 8b0cfa7
1 parent cf7acaa
commit 8b0cfa7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/superset/assets/src/visualizations/nvd3/LineMulti/LineMulti.jsx b/superset/assets/src/visualizations/nvd3/LineMulti/LineMulti.jsx
@@ -9,7 +9,7 @@ const propTypes = {
   width: PropTypes.number,
   height: PropTypes.number,
   annotationData: PropTypes.object,
-  datasource: PropTypes.array,
+  datasource: PropTypes.object,
   formData: PropTypes.object,
   onAddFilter: PropTypes.func,
   onError: PropTypes.func,

diff --git a/superset/assets/src/visualizations/nvd3/utils.js b/superset/assets/src/visualizations/nvd3/utils.js
@@ -181,7 +181,7 @@ export function getMaxLabelSize(svg, axisClass) {
   const tickTexts = svg.selectAll(`.${axisClass} g.tick text`);
   if (tickTexts.length > 0) {
     const lengths = tickTexts[0].map(text => text.getComputedTextLength());
-    return Math.ceil(Math.max(...lengths));
+    return Math.ceil(Math.max(0, ...lengths));
   }
   return 0;
 }