Skip to content

fix: VSA generation issues in verify-conforma-konflux-ta task #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
arewm wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: VSA generation issues in verify-conforma-konflux-ta task #3118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
728022f
fix: basename was missing when pushing a trusted artifact
arewm Feb 17, 2026
17339a9
fix: VSA output path and trailing newlines in task results
arewm Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions tasks/verify-conforma-konflux-ta/0.1/verify-conforma-konflux-ta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,22 +322,48 @@ spec:
if [[ "$(params.ENABLE_VSA)" == "true" ]]; then
EC_ARGS+=(--vsa --attestation-format=$(params.ATTESTATION_FORMAT))

# Extract local path from VSA_UPLOAD for output directory
# VSA_UPLOAD format is "local@/path/to/dir" (and may have additional backends)
VSA_LOCAL_PATH=$(echo "$(params.VSA_UPLOAD)" | grep -oE 'local@[^ ]+' | sed 's/^local@//' | head -n1)

if [[ "$(params.ATTESTATION_FORMAT)" == "dsse" ]]; then
if [[ -z "$(params.VSA_SIGNING_KEY)" ]]; then
echo "ERROR: VSA_SIGNING_KEY required for format=dsse" >&2
exit 1
fi
EC_ARGS+=(--vsa-signing-key "$(params.VSA_SIGNING_KEY)")
EC_ARGS+=(--vsa-upload "$(params.VSA_UPLOAD)")
fi

# ec requires --attestation-output-dir to be under /tmp or cwd.
# Write there first, then copy to the workdir so
# create-trusted-artifact includes them in the archive.
VSA_TMP_DIR="/tmp/vsa-output"
mkdir -p "$VSA_TMP_DIR"
EC_ARGS+=(--attestation-output-dir "$VSA_TMP_DIR")

if [[ -n "$VSA_LOCAL_PATH" ]]; then
echo "$VSA_LOCAL_PATH" > $(results.sourceDataArtifact.path)
fi

EC_ARGS+=(--vsa-upload "$(params.VSA_UPLOAD)")
echo "true" > $(results.VSA_GENERATED.path)
echo -n "true" > $(results.VSA_GENERATED.path)
else
echo "false" > $(results.VSA_GENERATED.path)
echo -n "false" > $(results.VSA_GENERATED.path)
fi

# Execute EC with constructed arguments
ec "${EC_ARGS[@]}"

# Copy VSA output from /tmp to workdir for trusted artifact archival
if [[ "$(params.ENABLE_VSA)" == "true" ]]; then
VSA_LOCAL_PATH=$(echo "$(params.VSA_UPLOAD)" | grep -oE 'local@[^ ]+' | sed 's/^local@//' | head -n1)
if [[ -n "$VSA_LOCAL_PATH" && -d "/tmp/vsa-output" ]]; then
mkdir -p "$VSA_LOCAL_PATH"
cp -r /tmp/vsa-output/* "$VSA_LOCAL_PATH"/ 2>/dev/null || true
echo "=== VSA output directory contents ==="
find "$VSA_LOCAL_PATH" -type f
fi
fi
env:
# POLICY_CONFIGURATION is passed via environment variable to safely handle JSON strings
# This avoids shell quoting issues when Tekton substitutes parameter values directly in scripts
Expand Down Expand Up @@ -450,6 +476,8 @@ spec:
value: $(params.ociStorage)
- name: workDir
value: /var/workdir
- name: sourceDataArtifact
value: $(results.sourceDataArtifact.path)

volumes:
- name: trusted-ca
Expand Down
Loading