cleanup: first batch of fixes for no-floating-promises eslint rule

eslint.config.mjs

@@ -40,6 +40,8 @@ export default [
       "@typescript-eslint/no-explicit-any": "off",
       // replacement of ESLint's no-redeclare with support for function overload
       "@typescript-eslint/no-redeclare": "error",
+      // require awaiting or .then() chaining for promises
+      "@typescript-eslint/no-floating-promises": "warn",
       // ignore line endings between Windows and Unix
       "prettier/prettier": ["error", { endOfLine: "auto" }],
     },
@@ -50,6 +52,10 @@ export default [
         ...globals.browser,
         ...globals.node,
       },
+      parserOptions: {
+        projectService: true,
+        tsconfigRootDir: import.meta.dirname,
+      },
     },
   },
   {

src/authn/ccloudProvider.ts

@@ -216,7 +216,11 @@ export class ConfluentCloudAuthProvider
       userInfo,
       session: undefined,
     });
-    (await getLaunchDarklyClient())?.identify({ key: userInfo.id });
+
+    const launchDarklyClient = await getLaunchDarklyClient();
+    if (launchDarklyClient) {
+      await launchDarklyClient.identify({ key: userInfo.id });
+    }
 
     void vscode.window.showInformationMessage(
       `Successfully signed in to Confluent Cloud as ${ccloudStatus.user?.username}`,
@@ -603,7 +607,7 @@ export class ConfluentCloudAuthProvider
       // if we had a session before, we need to remove it, as well as inform the Accounts action to
       // show the sign-in badge again
       if (this._session) {
-        this.handleSessionRemoved();
+        await this.handleSessionRemoved();
       } else {
         logger.debug(
           "No auth session, and no cached _session (for this extension instance) found to remove; not taking any action",
@@ -613,7 +617,7 @@ export class ConfluentCloudAuthProvider
       // SCENARIO 2: user signed in / auth session was added
       // add a new auth session to the Accounts action and populate this instance's cached session
       // state
-      this.handleSessionCreated(session);
+      await this.handleSessionCreated(session);
     }
   }
 

src/authz/schemaRegistry.ts

@@ -112,7 +112,7 @@ export function showNoSchemaAccessWarningNotification(): void {
     return;
   }
 
-  showWarningNotificationWithButtons(
+  void showWarningNotificationWithButtons(
     "You do not have permission to access schema(s) for this topic. Messages will still appear, but may not be deserializeable.",
     { "Don't Show Again": async () => await SCHEMA_RBAC_WARNINGS_ENABLED.update(false, true) },
   );

src/commands/connections.ts

@@ -154,7 +154,7 @@ export async function createNewDirectConnectionCommand() {
         // use it to open the Direct Connection form (form will populate the fields with spec values)
         openDirectConnectionForm(newSpec);
       } catch (error) {
-        showErrorNotificationWithButtons("Error parsing spec file. See logs for details.");
+        void showErrorNotificationWithButtons("Error parsing spec file. See logs for details.");
         logger.error(`Error parsing spec file: ${error}`);
         return;
       }
@@ -209,7 +209,7 @@ export async function editDirectConnectionCommand(item: ConnectionId | DirectEnv
     logger.error("Direct connection not found, can't edit");
     // possibly stale Resources view? this shouldn't happen
     window.showErrorMessage("Connection not found.");
-    ResourceViewProvider.getInstance().refresh();
+    await ResourceViewProvider.getInstance().refresh();
     return;
   }
 
@@ -230,7 +230,7 @@ export async function exportDirectConnectionCommand(item: DirectEnvironment | Di
   if (!spec) {
     logger.error("Direct connection not found, can't share");
     window.showErrorMessage("Connection not found.");
-    ResourceViewProvider.getInstance().refresh();
+    await ResourceViewProvider.getInstance().refresh();
     return;
   }
 
@@ -280,7 +280,7 @@ export async function exportDirectConnectionCommand(item: DirectEnvironment | Di
           });
       } catch (err) {
         logger.error(`Failed to save file: ${err}`);
-        showErrorNotificationWithButtons("Unable to save connection spec file.");
+        void showErrorNotificationWithButtons("Unable to save connection spec file.");
       }
     }
   }

src/commands/docker.ts

@@ -157,7 +157,7 @@ export async function runWorkflowWithProgress(
             } else {
               errorMsg = error.message;
             }
-            showErrorNotificationWithButtons(
+            void showErrorNotificationWithButtons(
               `Error ${start ? "starting" : "stopping"} ${workflow.resourceKind}: ${errorMsg}`,
             );
           }

src/commands/flinkArtifacts.ts

@@ -99,15 +99,15 @@ export async function uploadArtifactCommand(
       errorMessage = `${errorMessage} ${err.message}`;
     }
     logError(err, errorMessage);
-    showErrorNotificationWithButtons(errorMessage);
+    void showErrorNotificationWithButtons(errorMessage);
   }
 }
 
 export async function deleteArtifactCommand(
   selectedArtifact: FlinkArtifact | undefined,
 ): Promise<void> {
   if (!selectedArtifact) {
-    showErrorNotificationWithButtons("No Flink artifact selected for deletion.");
+    void showErrorNotificationWithButtons("No Flink artifact selected for deletion.");
     return;
   }
   const request: DeleteArtifactV1FlinkArtifactRequest = {

src/commands/flinkUDFs.ts

@@ -79,7 +79,7 @@ export async function deleteFlinkUDFCommand(selectedUdf: FlinkUdf): Promise<void
       },
     );
 
-    showInfoNotificationWithButtons(
+    void showInfoNotificationWithButtons(
       `UDF "${selectedUdf.name}" deleted successfully from Confluent Cloud.`,
     );
   } catch (err) {
@@ -99,7 +99,7 @@ export async function deleteFlinkUDFCommand(selectedUdf: FlinkUdf): Promise<void
       }
     }
     logError(err, errorMessage);
-    showErrorNotificationWithButtons(errorMessage);
+    void showErrorNotificationWithButtons(errorMessage);
   }
 }
 
@@ -204,7 +204,7 @@ export async function startGuidedUdfCreationCommand(selectedArtifact: FlinkArtif
         errorMessage = `${errorMessage}: ${err.message}`;
         logError(err, errorMessage);
       }
-      showErrorNotificationWithButtons(errorMessage);
+      void showErrorNotificationWithButtons(errorMessage);
     }
   }
 }

src/commands/index.ts

@@ -41,7 +41,7 @@ export function createWrappedCommand(
     // notification to the user
     const disabledMessage: string | undefined = await checkForExtensionDisabledReason();
     if (disabledMessage) {
-      showExtensionDisabledNotification(disabledMessage);
+      void showExtensionDisabledNotification(disabledMessage);
       return;
     }
 
@@ -55,9 +55,9 @@ export function createWrappedCommand(
       if (e instanceof Error) {
         // gather more (possibly-ResponseError) context and send to Sentry (only enabled in
         // production builds)
-        logError(e, `${commandName}`, { extra: { command: commandName } });
+        logError(e, commandName, { extra: { command: commandName } });
         // also show error notification to the user with default buttons
-        showErrorNotificationWithButtons(`Error invoking command "${commandName}": ${e}`);
+        void showErrorNotificationWithButtons(`Error invoking command "${commandName}": ${e}`);
       }
     }
   };

src/commands/schemas.ts

@@ -179,9 +179,7 @@ export async function openLatestSchemasCommand(topic: KafkaTopic) {
       title: message,
     },
     async () => {
-      const promises = highestVersionedSchemas.map((schema) => {
-        openReadOnlySchemaDocument(schema);
-      });
+      const promises = highestVersionedSchemas.map((schema) => openReadOnlySchemaDocument(schema));
       await Promise.all(promises);
     },
   );
@@ -263,7 +261,7 @@ export async function deleteSchemaVersionCommand(schema: Schema) {
     const found = schemaGroup && schemaGroup.find((s) => s.id === schema.id) !== undefined;
 
     if (!found) {
-      showErrorNotificationWithButtons("Schema not found in registry.", {
+      void showErrorNotificationWithButtons("Schema not found in registry.", {
         "Refresh Schemas": () => vscode.commands.executeCommand("confluent.schemas.refresh"),
         ...DEFAULT_ERROR_NOTIFICATION_BUTTONS,
       });
@@ -285,7 +283,7 @@ export async function deleteSchemaVersionCommand(schema: Schema) {
       }
     }
 
-    showErrorNotificationWithButtons("Schema not found in registry.", {
+    void showErrorNotificationWithButtons("Schema not found in registry.", {
       "Refresh Schemas": () => vscode.commands.executeCommand("confluent.schemas.refresh"),
       ...DEFAULT_ERROR_NOTIFICATION_BUTTONS,
     });
@@ -358,7 +356,7 @@ export async function deleteSchemaVersionCommand(schema: Schema) {
   } catch (e) {
     success = false;
     logError(e, "Error deleting schema version", { extra: { error: {} } });
-    showErrorNotificationWithButtons(
+    void showErrorNotificationWithButtons(
       `Error deleting schema version ${schema.version}: ${e instanceof Error ? e.message : String(e)}`,
     );
   }
@@ -396,7 +394,7 @@ export async function deleteSchemaSubjectCommand(subject: Subject) {
     schemaGroup = await loader.getSchemasForSubject(subject.environmentId, subject.name);
 
     if (!Array.isArray(schemaGroup) || schemaGroup.length === 0) {
-      showErrorNotificationWithButtons("Schema subject not found in registry.", {
+      void showErrorNotificationWithButtons("Schema subject not found in registry.", {
         "Refresh Schemas": () => vscode.commands.executeCommand("confluent.schemas.refresh"),
         ...DEFAULT_ERROR_NOTIFICATION_BUTTONS,
       });
@@ -414,7 +412,7 @@ export async function deleteSchemaSubjectCommand(subject: Subject) {
         });
       }
     }
-    showErrorNotificationWithButtons("Schema subject not found in registry.", {
+    void showErrorNotificationWithButtons("Schema subject not found in registry.", {
       "Refresh Schemas": () => vscode.commands.executeCommand("confluent.schemas.refresh"),
       ...DEFAULT_ERROR_NOTIFICATION_BUTTONS,
     });
@@ -480,7 +478,7 @@ export async function deleteSchemaSubjectCommand(subject: Subject) {
   } catch (e) {
     success = false;
     logError(e, "Error deleting schema subject", { extra: { error: {} } });
-    showErrorNotificationWithButtons(
+    void showErrorNotificationWithButtons(
       `Error deleting schema subject ${subject.name}: ${e instanceof Error ? e.message : String(e)}`,
     );
   } finally {

src/commands/topics.ts

@@ -160,7 +160,9 @@ async function editTopicConfig(topic: KafkaTopic): Promise<void> {
         const errorBody = await err.response.json();
         formError = errorBody.message;
       } else {
-        logError(err, "update topic config", { extra: { functionName: "validateOrUpdateConfig" } });
+        logError(err, "update topic config", {
+          extra: { functionName: "validateOrUpdateConfig" },
+        });
         if (err instanceof Error && err.message) formError = err.message;
       }
       return { success: false, message: formError };
@@ -266,7 +268,7 @@ export async function produceMessagesFromDocument(topic: KafkaTopic) {
       uriScheme: messageUri.scheme,
       problemCount: diagnostics.length,
     });
-    showErrorNotificationWithButtons(
+    void showErrorNotificationWithButtons(
       "Unable to produce message(s): JSON schema validation failed.",
       {
         "Show Validation Errors": () => {
@@ -479,7 +481,7 @@ async function produceMessages(
 
     // if we only have validation errors, no summary will be shown, but we should provide the
     // "Show Validation Errors" button
-    showErrorNotificationWithButtons(
+    void showErrorNotificationWithButtons(
       `Failed to produce ${errorResults.length.toLocaleString()}${ofTotal} message${plural} to topic "${topic.name}"${errorSummary ? `:\n${errorSummary}` : ""}`,
       buttons,
     );

src/consume.ts

@@ -535,8 +535,10 @@ function messageViewerStartPollingCommand(
             }
             default: {
               reportable = { message: "Something went wrong." };
-              logError(error, "message viewer", { extra: { status: status.toString(), payload } });
-              showErrorNotificationWithButtons("Error response while consuming messages.");
+              logError(error, "message viewer", {
+                extra: { status: status.toString(), payload },
+              });
+              void showErrorNotificationWithButtons("Error response while consuming messages.");
               break;
             }
           }

src/docker/workflows/base.ts

@@ -134,7 +134,7 @@ export abstract class LocalResourceWorkflow {
           errorMsg = error.response.statusText;
         }
       }
-      showErrorNotificationWithButtons(
+      void showErrorNotificationWithButtons(
         `Failed to start ${this.resourceKind} container "${container.name}": ${errorMsg}`,
       );
       return;

src/docker/workflows/confluent-local.ts

@@ -127,7 +127,7 @@ export class ConfluentLocalWorkflow extends LocalResourceWorkflow {
         containerEnvs,
       );
       if (!container) {
-        showErrorNotificationWithButtons(
+        void showErrorNotificationWithButtons(
           `Failed to create ${this.resourceKind} container "${brokerConfig.containerName}".`,
         );
         success = false;

src/docker/workflows/cp-schema-registry.ts

@@ -135,7 +135,7 @@ export class ConfluentPlatformSchemaRegistryWorkflow extends LocalResourceWorkfl
       kafkaNetworks,
     );
     if (!container) {
-      showErrorNotificationWithButtons(`Failed to create ${this.resourceKind} container.`);
+      void showErrorNotificationWithButtons(`Failed to create ${this.resourceKind} container.`);
       return;
     }
     this.sendTelemetryEvent(UserEvent.LocalDockerAction, {

src/errors.test.ts

@@ -186,7 +186,7 @@ describe("errors.ts extractResponseBody()", () => {
 
   it("should throw if the error is not a ResponseError", async () => {
     const error = new Error("test");
-    assert.rejects(
+    await assert.rejects(
       async () => {
         await extractResponseBody(error as any);
       },

src/errors.ts

@@ -125,7 +125,17 @@ export class CustomError extends Error {
  * @param message Text to add in the logger.error() message and top-level Sentry error message
  * @param sentryContext Optional Sentry context to include with the error
  * */
-export async function logError(
+export function logError(
+  e: unknown,
+  message: string,
+  sentryContext: Partial<ScopeContext> = {},
+): void {
+  _logError(e, message, sentryContext).catch((err) => {
+    logger.error(`Failed to log error: ${err}`, { originalError: String(e) });
+  });
+}
+
+async function _logError(
   e: unknown,
   message: string,
   sentryContext: Partial<ScopeContext> = {},

src/extension.ts

@@ -219,17 +219,19 @@ async function _activateExtension(
   ];
   logger.info("View providers initialized");
   // explicitly "reset" the Topics & Schemas views so no resources linger during reactivation/update
-  topicViewProvider.reset();
-  schemasViewProvider.reset();
+  await Promise.all([topicViewProvider.reset(), schemasViewProvider.reset()]);
 
   // Register refresh commands for our refreshable resource view providers.
   const refreshCommands: vscode.Disposable[] = [];
   for (const instance of getRefreshableViewProviders()) {
     refreshCommands.push(
-      registerCommandWithLogging(`confluent.${instance.kind}.refresh`, (): boolean => {
-        instance.refresh(true);
-        return true;
-      }),
+      registerCommandWithLogging(
+        `confluent.${instance.kind}.refresh`,
+        async (): Promise<boolean> => {
+          await instance.refresh(true);
+          return true;
+        },
+      ),
     );
   }
 
@@ -486,7 +488,7 @@ async function setupFeatureFlags(): Promise<void> {
 
   const disabledMessage: string | undefined = await checkForExtensionDisabledReason();
   if (disabledMessage) {
-    showExtensionDisabledNotification(disabledMessage);
+    void showExtensionDisabledNotification(disabledMessage);
     throw new Error(disabledMessage);
   }
 }
@@ -553,7 +555,10 @@ async function setupAuthProvider(): Promise<vscode.Disposable[]> {
       userInfo: undefined,
       session: cloudSession,
     });
-    (await getLaunchDarklyClient())?.identify({ key: cloudSession.account.id });
+    const launchDarklyClient = await getLaunchDarklyClient();
+    if (launchDarklyClient) {
+      await launchDarklyClient.identify({ key: cloudSession.account.id });
+    }
   }
 
   logger.info("Confluent Cloud auth provider registered");
@@ -587,7 +592,7 @@ export function deactivate() {
     const msg = "Error disposing telemetry logger during extension deactivation";
     logError(new Error(msg, { cause: e }), msg, { extra: {} });
   }
-  closeSentryClient();
+  void closeSentryClient();
 
   disposeLaunchDarklyClient();
   disableCCloudStatusPolling();

src/extensionSettings/listener.ts

@@ -54,7 +54,7 @@ export function createConfigChangeListener(): Disposable {
         // user toggled the "Enable Chat Participant" experimental setting
         const enabled: boolean = ENABLE_CHAT_PARTICIPANT.value;
         logger.debug(`"${ENABLE_CHAT_PARTICIPANT.id}" setting changed`, { enabled });
-        setContextValue(ContextValues.chatParticipantEnabled, enabled);
+        await setContextValue(ContextValues.chatParticipantEnabled, enabled);
         // telemetry for how often users opt in or out of the chat participant feature
         logUsage(UserEvent.ExtensionSettingsChange, {
           settingId: ENABLE_CHAT_PARTICIPANT.id,