Skip to content

Conversation

@ewencp
Copy link
Contributor

@ewencp ewencp commented Jan 27, 2015

This allows toggling ObjectMapper feature flags. I'm running into an issue now with features in Jackson that aren't permitted by default because they aren't always safe to combine. This hook lets me work around the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewencp What is the purpose of the wrapping?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly necessary, I just tend to prefer dependency injection at construction to mutators. We could just as easily change this to a call to setMapper() in Application.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@nehanarkhede
Copy link
Contributor

LGTM

ewencp added a commit that referenced this pull request Jan 29, 2015
Add hook to allow applications to configure the JSON ObjectMapper.
@ewencp ewencp merged commit 5693375 into master Jan 29, 2015
@ewencp ewencp deleted the configurable-json-object-mapper branch January 29, 2015 06:10
airlock-confluentinc bot pushed a commit that referenced this pull request Sep 10, 2024
Co-authored-by: Prince Raheja <114437476+rahejaprince@users.noreply.github.com>
Co-authored-by: ConfluentSemaphore <40306929+ConfluentSemaphore@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants