Skip to content

Conversation

@jvissers
Copy link
Contributor

@jvissers jvissers commented Mar 4, 2024

Exposes lastFailureReason from Recordcontext

@cla-assistant
Copy link

cla-assistant bot commented Mar 4, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


jvissers seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jvissers
Copy link
Contributor Author

jvissers commented Mar 4, 2024 via email

@rkolesnev
Copy link
Contributor

Hi @jvissers - is there a mismatch between email configured on your GH client / to do the commit and configured on your GH account? I think CLA bot is cross-checking on that - if they don't match - that may trip it over.
Can you please add the change to the CHANGELOG.adoc - it is a small change - but i think it is a useful one - so would be good to highlight in the changelog.

Thanks.

@rkolesnev
Copy link
Contributor

Here is a GH troubleshooting link for account / local account setup - if that helps troubleshooting-commits
Looking at the commit here - your username is not resolved as a link to GH user - there may be something missing in your local account setup - potentially that prevents CLA bot from working properly - as it cant resolve author on the commit to your GH user.

@jvissers
Copy link
Contributor Author

jvissers commented Mar 4, 2024 via email

@rkolesnev
Copy link
Contributor

rkolesnev commented Mar 4, 2024

could you please try to squash the commits on your branch or reset and recommit and then force push the changes?

Basically the first commit still has your oracle email associated with it - the local changes are not retrospective so they only applied to the 2nd commit (change to the changelog).

I am hoping that force-push with new commit(s) that have updated email - will let the check to re-evaluate properly.
Alternatively - new PR would need to be created - and should go through fine as long as commits in it are using your Gmail email.

Thanks.

If you run git log on your branch - you should only have commits with Author: jvissers <vissers.j@gmail.com> and not Author: jvissers <jan.vissers@oracle.com> -- as this one is not linked to your GH account i guess.

@jvissers jvissers closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants