fixes #329: Committing around transaction markers causes encoder to crash #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CVE-2020-8908: Files::createTempDir local information disclosure vulnerability #4011 - Only used transitively from tests, and is a deprecated function - google/guava#4011
astubbs
commented
Jul 6, 2022
parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/ParallelStreamProcessor.java
Show resolved
Hide resolved
Contributor
|
Looks good to me. Build failed though. |
Contributor
|
Failed on Enforcer check: |
New issues with WireMocks dep on Jetty BOM ~v9
…that Especially given we also use dependabot. If anyone is concerned to that level, they can use the plugin in their end user applications.
…e-tg # Conflicts: # pom.xml
# Conflicts: # pom.xml
astubbs
commented
Jul 11, 2022
parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/ParallelStreamProcessor.java
Show resolved
Hide resolved
astubbs
changed the title
astubbs
changed the title
# Conflicts: # pom.xml
Isolate fix to encoder system only. Makes more sense anyway as the field is what it is - truth. Changing it confuses the truth. And only the encoder needs the virtual representation, which it's more than capable of handling when required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #329
Test that committing can happen successfully when the base offset for the commit is adjacent to transaction markers in the input partitions.
The system assumes that the next expected (base committed) offset, will always be 1 offset above the highest succeeded. But tx makers can increase this gap from 1 to potentially much higher.
Blocked by: