Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add broker compatibility check #499

Merged
merged 4 commits into from
Dec 7, 2017
Merged

add broker compatibility check #499

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e1e76c
add broker compatibility check
dguy Nov 30, 2017
9778da2
use NetworkClientUtils
dguy Dec 5, 2017
b587d32
use consumer from broker compatibility check
dguy Dec 6, 2017
d5d0774
add comment
dguy Dec 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add comment
  • Loading branch information
@dguy
dguy committed Dec 7, 2017
commit d5d077498883df9da19196fa947ce9b6fa3d61a2
5 changes: 5 additions & 0 deletions ksql-rest-app/src/main/java/io/confluent/ksql/rest/server/BrokerCompatibilityCheck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ public static BrokerCompatibilityCheck create(final Map<String, Object> streamsC
/**
* Check if the used brokers have version 0.10.1.x or higher.
*
* <p>Note during an upgrade this check may pass or fail depending on
* which broker is the leader for the partition, i.e, if an old broker is the leader
* the check would fail. If a new broker is the leader it will pass. This is only
* a temporary situation and will naturally rectify itself.
*
* @throws KsqlException if brokers have version 0.10.0.x
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KSQL 0.2 and up need Kafka 0.11 since we need a bugfix in admin client that was merged in 0.11.
However, KSQL 0.1 will work with Kafka 0.10.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not it won't. Streams only works with kafka 0.10.1.x and higher

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hjafarpour the AdminClient bug fix, was that client only? i.e., we should be able to run with kafka 0.10.1.x and higher brokers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right @dguy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dguy yes, you are right. I was thinking about the KSQL dependency, but as you said it's client side and we should be fine with 0.10.1.x in broker side.

void checkCompatibility() throws StreamsException {
Expand Down