Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 10 support #1524

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Java 10 support #1524

merged 1 commit into from
Jul 4, 2018

Conversation

dguy
Copy link
Contributor

@dguy dguy commented Jul 3, 2018

Description

Update the version of fast-classpath-scanner to 3.1.6 which supports java 9+.
One fix in UDFLoader so that it works with the built-in UDFs

Fixes #1523

Testing done

Ran build on java 10 & java 8

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")

@dguy dguy requested review from big-andy-coates and apurvam July 3, 2018 14:39
apurvam
apurvam approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@apurvam apurvam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

hjafarpour
hjafarpour approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@hjafarpour hjafarpour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dguy dguy force-pushed the java10-support branch from 666abb6 to 07cd8da Compare July 4, 2018 10:01
@dguy dguy merged commit 7436496 into confluentinc:5.0.x Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apurvam apurvam apurvam approved these changes

@hjafarpour hjafarpour hjafarpour approved these changes

@big-andy-coates big-andy-coates Awaiting requested review from big-andy-coates

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dguy @apurvam @hjafarpour