Skip to content

Conversation

ayushRanjanCnflt
Copy link
Member

Description

What behavior do you want to change, why, how does your patch achieve the changes?

Testing done

Describe the testing strategy. Unit and integration tests are expected for any behavior changes.

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

@Copilot Copilot AI review requested due to automatic review settings August 16, 2025 17:17
@ayushRanjanCnflt ayushRanjanCnflt requested a review from a team as a code owner August 16, 2025 17:17
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces CI pipeline optimizations by modifying Semaphore configuration to improve build queue management and resource utilization.

  • Excludes the pipeline-opt branch from parallel processing restrictions
  • Adds auto-cancellation of queued builds specifically for the master branch

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


queue:
- when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x'"
- when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x' and branch != 'pipeline-opt'"
Copy link
Preview

Copilot AI Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding the branch name 'pipeline-opt' in the CI configuration creates a maintenance burden. Consider using a more generic pattern or environment variable to avoid needing to update the CI config for each optimization branch.

Suggested change
- when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x' and branch != 'pipeline-opt'"
- when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x' and branch !~ 'pipeline-opt.*'"

Copilot uses AI. Check for mistakes.


auto_cancel:
queued:
when: "branch == 'master'"
Copy link
Preview

Copilot AI Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-cancelling queued builds only on the master branch may not be the intended behavior. Typically, auto-cancellation is more useful for feature branches to avoid running outdated builds when new commits are pushed. Consider if this should apply to all branches or if the logic should be inverted.

Suggested change
when: "branch == 'master'"
when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x' and branch != 'pipeline-opt'"

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant