-
Notifications
You must be signed in to change notification settings - Fork 1k
[wip] pipeline optimization #10797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[wip] pipeline optimization #10797
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces CI pipeline optimizations by modifying Semaphore configuration to improve build queue management and resource utilization.
- Excludes the
pipeline-opt
branch from parallel processing restrictions - Adds auto-cancellation of queued builds specifically for the master branch
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.semaphore/semaphore.yml
Outdated
|
||
queue: | ||
- when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x'" | ||
- when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x' and branch != 'pipeline-opt'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding the branch name 'pipeline-opt' in the CI configuration creates a maintenance burden. Consider using a more generic pattern or environment variable to avoid needing to update the CI config for each optimization branch.
- when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x' and branch != 'pipeline-opt'" | |
- when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x' and branch !~ 'pipeline-opt.*'" |
Copilot uses AI. Check for mistakes.
.semaphore/semaphore.yml
Outdated
|
||
auto_cancel: | ||
queued: | ||
when: "branch == 'master'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-cancelling queued builds only on the master branch may not be the intended behavior. Typically, auto-cancellation is more useful for feature branches to avoid running outdated builds when new commits are pushed. Consider if this should apply to all branches or if the logic should be inverted.
when: "branch == 'master'" | |
when: "branch != 'master' and branch !~ '[0-9]+\\.[0-9]+\\.x' and branch != 'pipeline-opt'" |
Copilot uses AI. Check for mistakes.
Description
What behavior do you want to change, why, how does your patch achieve the changes?
Testing done
Describe the testing strategy. Unit and integration tests are expected for any behavior changes.
Reviewer checklist