Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented IntFromBoolean UDF #10012

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implemented IntFromBoolean UDF #10012

wants to merge 1 commit into from

Conversation

rgibaiev
Copy link

@rgibaiev rgibaiev commented Jul 14, 2023 •
edited
Loading

Description

Added new UDF that converts Boolean to Integer. Fixes #9898

Testing done

Unit test added

Reviewer checklist

  • Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).
  • Ensure relevant issues are linked (description should include text like "Fixes #")
  • Do these changes have compatibility implications for rollback? If so, ensure that the ksql command version is bumped.

@rgibaiev rgibaiev requested a review from a team as a code owner July 14, 2023 12:42
@rgibaiev rgibaiev force-pushed the feature-issue-9898-bool-to-int branch from eed1ce5 to 6561348 Compare July 14, 2023 20:08
@TheDarkFlame
Copy link

Probably makes more sense to try and put this into the CAST than as a UDF.

@rgibaiev
Copy link
Author

rgibaiev commented Aug 6, 2023

Feel free to port it there yourself if you want

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Nov 15, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cast Boolean to Int
2 participants
@rgibaiev @TheDarkFlame