Remove jconsole dependency for ksql-tools. (#703)

Get rid of the sun jconsole dependency for ksql-tools. We were using this to figure out the JMX URL for the ksql service. Instead, require the user of PrintMetrics to provide the JMX port as a parameter
confluentinc · Feb 7, 2018 · e43aa2a · e43aa2a
1 parent 1433d1b
commit e43aa2a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 48 deletions.
diff --git a/ksql-tools/pom.xml b/ksql-tools/pom.xml
@@ -70,15 +70,6 @@
             <scope>test</scope>
         </dependency>
 
-        <dependency>
-            <groupId>sun.jdk</groupId>
-            <artifactId>jconsole</artifactId>
-            <version>1.8</version>
-            <scope>system</scope>
-            <systemPath>${java.home}/../lib/jconsole.jar</systemPath>
-        </dependency>
-
-
     </dependencies>
 
     <build>

diff --git a/ksql-tools/src/main/java/io/confluent/ksql/tools/printmetrics/PrintMetrics.java b/ksql-tools/src/main/java/io/confluent/ksql/tools/printmetrics/PrintMetrics.java
@@ -16,13 +16,9 @@
 
 package io.confluent.ksql.tools.printmetrics;
 
-import sun.tools.jconsole.LocalVirtualMachine;
-
 import java.io.IOException;
-import java.net.MalformedURLException;
 import java.util.LinkedList;
 import java.util.List;
-import java.util.Map;
 import java.util.Set;
 
 import javax.management.MBeanAttributeInfo;
@@ -37,7 +33,7 @@ public class PrintMetrics {
 
   public static void printHelp() {
     System.err.println(
-        "usage: PrintMetrics [help] pid=<KSQL PID>\n" +
+        "usage: PrintMetrics [help] port=<KSQL JMX Port>\n" +
             "\n" +
             "This utility prints the following operational metrics tracked by ksql:\n" +
             "\n" +
@@ -54,34 +50,15 @@ public static void printHelp() {
             "num-persistent-queries:    The number of queries currently executing.\n" +
             "num-active-queries:        The number of queries actively processing messages.\n" +
             "num-idle-queries:          The number of queries with no messages available to " +
-            "process.");
+            "process.\n");
+    System.err.println(
+        "To use this tool, when running ksql-server-start you must set the JMX_PORT " +
+        "environmnent variable to an open port for the JMX service to listen on.");
   }
 
-  private static void printMetrics(int pid) throws IOException {
-    // get all the jvms running locally and find the one we are interested in
-    Map<Integer, LocalVirtualMachine> jvms = LocalVirtualMachine.getAllVirtualMachines();
-    LocalVirtualMachine ksqlJvm = null;
-    if (pid == -1) {
-      for (LocalVirtualMachine jvm : jvms.values()) {
-        System.out.println(jvm.displayName());
-        if (jvm.displayName().startsWith("io.confluent.ksql.rest.server.KsqlRestApplication")) {
-          ksqlJvm = jvm;
-        }
-      }
-    } else {
-      ksqlJvm = jvms.get(pid);
-    }
-    if (ksqlJvm == null) {
-      throw new PrintMetricsException("Could not find vm with pid " + pid);
-    }
-
-    String jvmAddress = ksqlJvm.connectorAddress();
-    JMXServiceURL jmxURL;
-    try {
-      jmxURL = new JMXServiceURL(jvmAddress);
-    } catch (MalformedURLException e) {
-      throw new PrintMetricsException(String.format("No JVM at PID %d", pid));
-    }
+  private static void printMetrics(int port) throws IOException {
+    JMXServiceURL jmxURL = new JMXServiceURL(
+        String.format("service:jmx:rmi:///jndi/rmi://localhost:%d/jmxrmi", port));
     JMXConnector connector = JMXConnectorFactory.connect(jmxURL);
     connector.connect();
     MBeanServerConnection connection = connector.getMBeanServerConnection();
@@ -125,22 +102,22 @@ public static void main(String[] progArgs) throws IOException {
       return;
     }
 
-    printMetrics(args.pid);
+    printMetrics(args.port);
   }
 
   static class Arguments {
 
     public boolean help;
-    public int pid;
+    public int port;
 
-    public Arguments(boolean help, int pid) {
+    public Arguments(boolean help, int port) {
       this.help = help;
-      this.pid = pid;
+      this.port = port;
     }
 
     public static Arguments parse(String[] args) {
       boolean help = false;
-      int pid = -1;
+      int port = -1;
 
       for (String arg : args) {
         if ("help".equals(arg)) {
@@ -169,16 +146,16 @@ public static Arguments parse(String[] args) {
         }
 
         switch (argName) {
-          case "pid":
-            pid = Integer.decode(argValue);
+          case "port":
+            port = Integer.decode(argValue);
             break;
           default: {
             throw new ArgumentParseException(
                 String.format("Invalid argument value '%s'", argName));
           }
         }
       }
-      return new Arguments(help, pid);
+      return new Arguments(help, port);
     }
   }
 }