-
Notifications
You must be signed in to change notification settings - Fork 7
GH-32: Switch from Gradle to Maven for build tool #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we add something to the maven central distribution directing people to confluent hub for new versions? I'm not sure if this is a thing, just thinking |
I'm not sure--I've never seen something like that done. I can think of two potential gotchas that we'd want to avoid if we do decide to try something like that:
I'm also totally fine if the folks at WePay want to continue pushing to Maven Central; Maven is designed for this kind of thing, after all, so theoretically it shouldn't be too hard to port that logic over to this new build system. |
I am not aware of any standard way to point people at new package spaces in Maven Central. My vote is not to worry about it. Let's just publish in Confluent hub. If it's an issue on our end, we can push to Maven Central as well, but I think it should be fine. |
@C0urante one thing to clarify, does Confluent Hub offer a publicly accessible Maven-compatible repo? We're not using |
@criccomini Confluent Hub does not offer a Maven mirror; we package connectors into a ZIP archive that includes (among other things) the connector JAR and all of its dependencies. If you'd rather not adjust your tooling to work with that, do you think you could port over the build-a-tarball-and-deploy-to-Maven-Central logic? |
Gotcha. Ok, we'll probably have to implement Maven central publication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Addresses most #32:
Still remaining is the addition of a
Jenkinsfile
, which will allow us to fully integrate this project into Confluent's CI/CD pipeline.This PR targets the earliest feature branch, 1.1.x. If it's approved, I'll merge and then update the later branches as well.
This removes the ability to publish the tarball archive to Maven central; we think Confluent Hub is a good enough release vehicle for now. If someone wants to add that back to the project, though, PRs welcome :)