Stop the hanging threads in runner client forcefully after 30 seconds #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add logging * add logging * add logging
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
|
|
imcdo
approved these changes
Sep 25, 2024
|
can you update the CODEONWERS file and add cp-test-frameworks team. |
|
@PrasanthV454 For now I've added them in review, in separate PR will make the change today. |
@sprsi : Can you plz add sample semaphore job runs - 1 with upgrade tests and 1-2 with system tests (across branches say 7.3.x and 7.6.x) using this commit to ensure there is no regression. |
imcdo
approved these changes
Sep 26, 2024
|
@prayadav-cp These are the runs on the new branch, looks good to me! |
prayadav-cp
approved these changes
Sep 30, 2024
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple threads are spawned while running tests and ultimately all of them need to join() to finish and publish the results (be it a success or a failure). However, if one or more threads don’t join(), they will eventually complete but the timing is non-deterministic.
This PR solves this join() issue (or rather harden the runner client threading mechanism)