Don't send empty credentials to SR in Authorization Header #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
suggested changes
May 13, 2020
tests/schema_registry/conftest.py
Outdated
| headers = request._request.headers | ||
|
|
||
| # Pass request to downstream matchers | ||
| if 'Authorization' not in headers.keys(): |
There was a problem hiding this comment.
I'm not sure how this works under the hood, but this seems like it needs to scan keys() for 'Authorization', would suggest using ..keys().get('Authorization', None)
tests/schema_registry/conftest.py
Outdated
| if 'Authorization' not in headers.keys(): | ||
| return None | ||
|
|
||
| userinfo = headers.get('Authorization').split(" ")[1] |
There was a problem hiding this comment.
And here's a second lookup. Just do one lookup.
There was a problem hiding this comment.
Inconsistent use of single/double quotes on the same line.
There was a problem hiding this comment.
Will throw an IndexError if the Authorization header does not contain a space, but maybe that's okay here.
tests/schema_registry/conftest.py
Outdated
| # Authenticated, pass downstream | ||
| return None | ||
|
|
||
| unauhtorized = {'error_code': 401, |
tests/schema_registry/conftest.py
Outdated
| 'message': "401 Unauthorized"} | ||
| return create_response(request=request, | ||
| status_code=401, | ||
| json=unauhtorized) |
|
|
||
| Verify that the package works, should print the expected Python client | ||
| and librdkafka versions: | ||
|
|
||
| $ python -c 'import confluent_kafka as ck ; print "py:", ck.version(), "c:", ck.libversion()' | ||
| $ python -c 'import confluent_kafka as ck ; print "py: {} c: {}" \ |
There was a problem hiding this comment.
This will not work for python3
edenhill
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.