Skip to content

Conversation

@dpfeif
Copy link
Contributor

@dpfeif dpfeif commented Nov 18, 2019

This is meant to fix #659

@ghost
Copy link

ghost commented Nov 18, 2019

It looks like @dpfeif hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

@dpfeif
Copy link
Contributor Author

dpfeif commented Nov 18, 2019

[clabot:check]

@ghost
Copy link

ghost commented Nov 18, 2019

@confluentinc It looks like @dpfeif just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@dpfeif
Copy link
Contributor Author

dpfeif commented Nov 20, 2019

I'm unable to see the link between the proposed changes and the AppVeyor build failing: https://ci.appveyor.com/project/ConfluentClientEngineering/confluent-kafka-python/builds/28935232

@nysthee
Copy link

nysthee commented Nov 22, 2019

Seems the Windows builds are failing on master as well.

@edenhill
Copy link
Contributor

Looking into the windows build failures, seems to be caused by cibuildwheel upgrade

@nysthee
Copy link

nysthee commented Dec 6, 2019

@edenhill can we assist on the failing build? We are eager to have this PR build successfully and reviewed.

@edenhill
Copy link
Contributor

edenhill commented Dec 6, 2019

Rebasing this PR on latest master should sort out the build issues.

Copy link
Contributor

@rnpridgeon rnpridgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll get it in after finalizing the 1.3.0 release.

@nysthee
Copy link

nysthee commented Jan 14, 2020

Hi @rnpridgeon when is this meant to be merged?

@rnpridgeon rnpridgeon merged commit e575850 into confluentinc:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support disable auto register schema

4 participants