-
Notifications
You must be signed in to change notification settings - Fork 915
Add disable auto register schemas #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disable auto register schemas #718
Conversation
It looks like @dpfeif hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
[clabot:check] |
@confluentinc It looks like @dpfeif just signed our Contributor License Agreement. 👍 Always at your service, clabot |
I'm unable to see the link between the proposed changes and the AppVeyor build failing: https://ci.appveyor.com/project/ConfluentClientEngineering/confluent-kafka-python/builds/28935232 |
Seems the Windows builds are failing on master as well. |
Looking into the windows build failures, seems to be caused by cibuildwheel upgrade |
@edenhill can we assist on the failing build? We are eager to have this PR build successfully and reviewed. |
Rebasing this PR on latest master should sort out the build issues. |
This is meant to fix #659
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll get it in after finalizing the 1.3.0 release.
Hi @rnpridgeon when is this meant to be merged? |
This is meant to fix #659