-
Notifications
You must be signed in to change notification settings - Fork 915
Update README.md #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #668
Conversation
It looks like @andreyferriyan hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here. Once you've signed reply with Appreciation of efforts, clabot |
|
@confluentinc It looks like @andreyferriyan just signed our Contributor License Agreement. 👍 Always at your service, clabot |
README.md
Outdated
|
||
To avoid error in installation like *no matches found: confluent-kafka[avro]*, use double quotes. As an example: | ||
|
||
$ pip install "confluent-kafka[avro]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to just change the "pip install ..avro]" line above to include quotes, people tend to cutnpaste the first command they see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this is my first time to change. Where should I change the line ?. In my forking repo ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, undo your previous changes and modify the original pip install confluent-kafka[avro]
line above to have quotes. Commit and push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good to go, just the remove whitespace changes you've made.
README.md
Outdated
|
||
**Install from source from PyPi** *(requires librdkafka + dependencies to be installed separately)*: | ||
|
||
$ pip install --no-binary :all: confluent-kafka | ||
|
||
|
||
For source install, see *Prerequisites* below. | ||
For source install, see *Prerequisites* below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the whitespace diff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whitespace change needs to be removed too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about like this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this is okay, hehe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect :)
Update README.md in installation section. To avoid error with different shell.