Skip to content

implement environment markers to fix poetry #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2019

Conversation

fishman
Copy link

@fishman fishman commented Apr 16, 2019

pep 508 recommends the usage of environment markers rather than version_info
https://www.python.org/dev/peps/pep-0508/#environment-markers

currently installing using poetry resolves the wrong libraries

@ghost
Copy link

ghost commented Apr 16, 2019

It looks like @fishman hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

pep 508 recommends the usage of environment markers rather than version_info
https://www.python.org/dev/peps/pep-0508/#environment-markers

currently installing using poetry resolves the wrong libraries
@fishman
Copy link
Author

fishman commented Apr 16, 2019

[clabot:check]

@ghost
Copy link

ghost commented Apr 16, 2019

@confluentinc It looks like @fishman just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@fishman fishman force-pushed the follow-pep-508-to-fix-poetry branch from e4fdd65 to 4e6250d Compare April 16, 2019 17:15
@fishman
Copy link
Author

fishman commented Apr 23, 2019

@edenhill can we get this merged? It breaks pretty much all python 3.6/3.7 installs by installing enum34 on an unsupported platform. It also goes against https://www.python.org/dev/peps/pep-0508/#environment-markers

It's a non intrusive change that fixes a lot of environments. python-poetry/poetry#844 (comment)

@edenhill edenhill merged commit f9810ad into confluentinc:master Apr 23, 2019
@edenhill
Copy link
Contributor

Awesome, thank you!

@fishman
Copy link
Author

fishman commented May 13, 2019

@edenhill is there any chance you can do a 1.0.1 service release ? right now i still have to manually remove enum34 after installing anywhere i use poetry

@fishman fishman deleted the follow-pep-508-to-fix-poetry branch May 13, 2019 17:33
@edenhill
Copy link
Contributor

We're aiming to do a 1.0.1 maintenance release (with this fix and other ones) within a couple of weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants