Support encoding with fastavro #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnpridgeon
force-pushed
the
fast_avro_writer
branch
from
cf2b83b to
5d00428
Compare
edenhill
suggested changes
Nov 26, 2018
edenhill
reviewed
Nov 26, 2018
| @@ -140,13 +140,9 @@ def encode_record_with_schema_id(self, schema_id, record, is_key=False): | |||
| with ContextStringIO() as outf: | |||
| # write the header | |||
| # magic byte | |||
| outf.write(struct.pack('b', MAGIC_BYTE)) | |||
|
|
|||
| # write the schema ID in network byte order (big end) | |||
There was a problem hiding this comment.
nit: this comment still applies though
edenhill
reviewed
Nov 27, 2018
| @@ -136,19 +140,11 @@ def encode_record_with_schema_id(self, schema_id, record, is_key=False): | |||
| with ContextStringIO() as outf: | |||
| # write the header | |||
There was a problem hiding this comment.
nit: these three comment lines read strange now. combine them into one.
edenhill
reviewed
Nov 27, 2018
| # write the schema ID in network byte order (big end) | ||
|
|
||
| outf.write(struct.pack('>I', schema_id)) | ||
| # Write the magic byte and schema ID in network byte order (big end) |
There was a problem hiding this comment.
micronit: "big endian" (from original comment though)
edenhill
reviewed
Nov 27, 2018
| @@ -138,7 +138,7 @@ def encode_record_with_schema_id(self, schema_id, record, is_key=False): | |||
| # get the writer | |||
| writer = self.id_to_writers[schema_id] | |||
| with ContextStringIO() as outf: | |||
| # Write the magic byte and schema ID in network byte order (big end) | |||
| # Write the magic byte and schema ID in network byte order (big endian) | |||
edenhill
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrap up work contributed by #419