Fix for issue #443.

[charlie-white]

Fixing two small coding issues in update_compatibility and get_compatibility methods.
No acccompanying tests as the mock object is incomplete and I didn't have time to dive in deep enough to fix that.

[ghost]

It looks like @charlie-white hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

[edenhill]

[clabot:check]

[ghost]

@confluentinc It looks like @charlie-white just signed our Contributor License Agreement. 👍

Always at your service,

clabot

[rnpridgeon]

Thanks @charlie-white,

I'll have to insist that an integration test be added so we can catch this issue earlier in the unlikely even the schema registry api changes in the future. Really we should have a test for each endpoint but that's another issue.

Other than that the fix LGTM

[edenhill]

this seems to contradict the API docs:
https://docs.confluent.io/current/schema-registry/docs/api.html#put--config

code:
https://github.com/confluentinc/schema-registry/blob/8831bbd73ea720fcd279032a5fffabbdb1a1f2b1/client/src/main/java/io/confluent/kafka/schemaregistry/client/rest/entities/Config.java#L25

[rnpridgeon]

I have opened a docs jira for this. This absolutely the case I ran into the same issue implementing the SR client in golang.

see DOCS-762 @edenhill

I had to handle it as follows:

/* NOTE: GET uses compatibilityLevel, POST uses compatibility */
type compatibilityLevel struct {
	CompatibilityUpdate Compatibility `json:"compatibility,omitempty"`
	Compatibility       Compatibility `json:"compatibilityLevel,omitempty"`
}

[rnpridgeon]

Rolled into #440 with schema registry client integration tests. Thanks for you contribution